lkml.org 
[lkml]   [2008]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 15/37] PNPACPI: pass pnp_dev instead of acpi_handle
    Pass the pnp_dev pointer when possible instead of the acpi_handle.
    This allows better error messages and reduces the chance of error
    in the caller.

    Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

    Index: work7/drivers/pnp/pnpacpi/core.c
    ===================================================================
    --- work7.orig/drivers/pnp/pnpacpi/core.c 2008-03-21 15:35:05.000000000 -0600
    +++ work7/drivers/pnp/pnpacpi/core.c 2008-03-21 15:36:00.000000000 -0600
    @@ -88,10 +88,10 @@
    {
    acpi_handle handle = dev->data;
    struct acpi_buffer buffer;
    - int ret = 0;
    + int ret;
    acpi_status status;

    - ret = pnpacpi_build_resource_template(handle, &buffer);
    + ret = pnpacpi_build_resource_template(dev, &buffer);
    if (ret)
    return ret;
    ret = pnpacpi_encode_resources(res, &buffer);
    Index: work7/drivers/pnp/pnpacpi/pnpacpi.h
    ===================================================================
    --- work7.orig/drivers/pnp/pnpacpi/pnpacpi.h 2008-03-21 15:28:07.000000000 -0600
    +++ work7/drivers/pnp/pnpacpi/pnpacpi.h 2008-03-21 15:36:00.000000000 -0600
    @@ -8,5 +8,5 @@
    acpi_status pnpacpi_parse_allocated_resource(acpi_handle, struct pnp_resource_table*);
    acpi_status pnpacpi_parse_resource_option_data(acpi_handle, struct pnp_dev*);
    int pnpacpi_encode_resources(struct pnp_resource_table *, struct acpi_buffer *);
    -int pnpacpi_build_resource_template(acpi_handle, struct acpi_buffer*);
    +int pnpacpi_build_resource_template(struct pnp_dev *, struct acpi_buffer *);
    #endif
    Index: work7/drivers/pnp/pnpacpi/rsparser.c
    ===================================================================
    --- work7.orig/drivers/pnp/pnpacpi/rsparser.c 2008-03-21 15:35:59.000000000 -0600
    +++ work7/drivers/pnp/pnpacpi/rsparser.c 2008-03-21 15:36:00.000000000 -0600
    @@ -775,9 +775,10 @@
    return AE_OK;
    }

    -int pnpacpi_build_resource_template(acpi_handle handle,
    +int pnpacpi_build_resource_template(struct pnp_dev *dev,
    struct acpi_buffer *buffer)
    {
    + acpi_handle handle = dev->data;
    struct acpi_resource *resource;
    int res_cnt = 0;
    acpi_status status;
    --


    \
     
     \ /
      Last update: 2008-03-26 18:41    [W:0.023 / U:18.188 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site