lkml.org 
[lkml]   [2008]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] bkl2mtd: cleanup
On Wed, 26 March 2008 10:48:21 +0000, Al Viro wrote:
>
> > -static int _block2mtd_write(struct block2mtd_dev *dev, const u_char *buf,
> > - loff_t to, size_t len, size_t *retlen)
> > +static int
> > +_block2mtd_write(struct block2mtd_dev *dev, const u_char *buf, loff_t to,
> > + size_t len, size_t *retlen)
>
> That's actually worse... BTW, single-underscore-... for identifiers? Odd.

Indeed. Must have been my fault.

> OTOH, you've missed quite a few of my pet peeves, starting with
> u_char in the quoted part...

A large-scale s/u_char/void/ over mtd read and write functions wouldn't
hurt, no doubt. Currently every other driver contains a cast to
(u_char*) or three for no gain afaics.

Jörn

--
Never argue with idiots - first they drag you down to their level,
then they beat you with experience.
-- unknown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-03-26 12:01    [W:1.142 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site