lkml.org 
[lkml]   [2008]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] [Blackfin try #2] char driver for Blackfin on-chip OTP memory
On 03/27/2008 02:08 AM, Bryan Wu wrote:
> From: Mike Frysinger <vapier.adi@gmail.com>
>
> initial char driver for otp memory
> (only read supported atm ... needs real examples/docs for write support)
>
> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>

Nice,
Acked-by: Jiri Slaby <jirislaby@gmail.com>

> diff --git a/drivers/char/bfin-otp.c b/drivers/char/bfin-otp.c
> new file mode 100644
> index 0000000..2edc284
> --- /dev/null
> +++ b/drivers/char/bfin-otp.c
[...]
> +static int __init bfin_otp_init(void)
> +{
> + int ret;
> +
> + stampit();
> +
> + ret = misc_register(&bfin_otp_misc_device);
> + if (ret) {
> + pr_init(KERN_ERR PFX "unable to register a misc device\n");
> + return ret;
> + }
> +
> + pr_init(KERN_INFO PFX "initialized\n");

except the fact, that pr_init definition seems to be broken. Its defined __fmt
is const, so it should reside in .init.rodata (__initconst), not .init.data
(__initdata).


\
 
 \ /
  Last update: 2008-03-26 11:37    [W:0.107 / U:0.160 seconds]
©2003-2011 Jasper Spaans. Advertise on this site