Messages in this thread | | | Date | Tue, 25 Mar 2008 11:48:31 +0100 | From | Rodolfo Giometti <> | Subject | Re: [PATCH 1/7] LinuxPPS core support. |
| |
On Fri, Mar 21, 2008 at 06:00:05PM +0100, Kay Sievers wrote: > On Fri, 2008-03-21 at 11:56 +0100, Rodolfo Giometti wrote: > > On Fri, Mar 21, 2008 at 04:36:44AM +0100, Kay Sievers wrote: > > > On Thu, Mar 6, 2008 at 1:09 PM, Rodolfo Giometti <giometti@linux.it> wrote: > > > > This patch adds the kernel side of the PPS support currently named > > > > "LinuxPPS". > > > > > > > diff --git a/drivers/pps/sysfs.c b/drivers/pps/sysfs.c > > > > new file mode 100644 > > > > index 0000000..c25c91c > > > > --- /dev/null > > > > +++ b/drivers/pps/sysfs.c > > > > @@ -0,0 +1,130 @@ > > > > > > > +void pps_sysfs_remove_source_entry(struct pps_device *pps) > > > > +{ > > > > + /* Delete info files */ > > > > + sysfs_remove_group(&pps->dev->kobj, &pps_group); > > > > +} > > > > + > > > > +int pps_sysfs_create_source_entry(struct pps_device *pps) > > > > +{ > > > > + int ret; > > > > + > > > > + /* Create info files */ > > > > + ret = sysfs_create_group(&pps->dev->kobj, &pps_group); > > > > > > Any specific reason you are creating the group by hand, and not assign > > > it to the default group in your class? It would will let the core > > > handle it for you. The device add uevent to userspace will happen > > > before you added the attributes, which is usually not nice. > > > > No any specific reason... I just supposed it was the-right-think(TM)! > > :) > > > > Can you please suggest me an URL where I can see how to rework the > > code? > > You can assign class->dev_attrs the array of attributes, and the driver > core will create these attributes for all devices that get registered > with that class. See: drivers/base/core.c :: device_add_attrs().
Fixed, I'll provide a new patch ASAP.
Thanks,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti@enneenne.com Linux Device Driver giometti@gnudd.com Embedded Systems giometti@linux.it UNIX programming phone: +39 349 2432127
| |