Messages in this thread |  | | | Subject | Re: [RFC 5/8] x86_64: Add UV specific header for MMR definitions | | From | Andi Kleen <> | | Date | 25 Mar 2008 11:04:22 +0100 | |
Christoph Hellwig <hch@infradead.org> writes:
> On Mon, Mar 24, 2008 at 01:21:16PM -0500, Jack Steiner wrote:
> >
> > Definitions of UV MMRs.
> > Note: this file is auto-generated by hardware design tools.
>
> Which is still not an excuse for the crap in there. Please submit a
> proper header with the needed defintions and shift & mask defintions and
> helpers instead of the bitfields.
bitfields are only problematic on portable code, which this isn't.
-Andi
|  |