[lkml]   [2008]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] x86 floppy: kill off the 'register' keyword from header

    When compilers became generally better at optimizing code than humans, the
    register keyword became mostly useless. For the floppy driver it certainly
    is since it's so slow compared to the rest of the system that optimizing
    access to a single variable or two isn't going to make any real
    So let's just leave it to the compiler - it'll do a better job anyway.

    This patch does away with a few register keywords in the x86 floppy driver.

    Signed-off-by: Jesper Juhl <>

    floppy.h | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/include/asm-x86/floppy.h b/include/asm-x86/floppy.h
    index a48d715..31b0d80 100644
    --- a/include/asm-x86/floppy.h
    +++ b/include/asm-x86/floppy.h
    @@ -52,7 +52,7 @@ static int doing_pdma;

    static irqreturn_t floppy_hardint(int irq, void *dev_id)
    - register unsigned char st;
    + unsigned char st;

    #undef TRACE_FLPY_INT

    @@ -70,8 +70,8 @@ static irqreturn_t floppy_hardint(int irq, void *dev_id)

    - register int lcount;
    - register char *lptr;
    + int lcount;
    + char *lptr;

    st = 1;
    for(lcount=virtual_dma_count, lptr=virtual_dma_addr;

     \ /
      Last update: 2008-03-26 02:19    [W:0.019 / U:18.792 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site