Messages in this thread | | | Date | Tue, 25 Mar 2008 21:15:10 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 019/148] include/asm-x86/cpufeature.h: checkpatch cleanups - formatting only |
| |
* Joe Perches <joe@perches.com> wrote:
> On Tue, 2008-03-25 at 16:30 +0100, Ingo Molnar wrote: > > > +#define X86_FEATURE_REP_GOOD _CF(3, 16) /* rep microcode works well > > > + * on this CPU */ > > that is crap too ... > > the _CF or the newly line-broken comment?
both :) Line-breaking in macros isnt done like that. And the _CF thing:
+#if defined _CF +#undef _CF +#endif +#define _CF(word, bit) ((word) * 32 + (bit))
looks quite ugly - either we have such a macro in which case it should be a generic define somewhere that doesnt override anything else, or we shouldnt do it.
I also had to fix some other typos that broke the 64-bit build. I ended up skipping the whole cpufeatures.h patch - could you please re-do and re-send it?
Ingo
| |