lkml.org 
[lkml]   [2008]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: tick-common.c hack for s390 needed
    On Tue, Mar 25, 2008 at 08:09:15PM +0100, Thomas Gleixner wrote:
    > On Sun, 23 Mar 2008, Russell King wrote:
    >
    > > On Sat, Mar 22, 2008 at 09:32:23PM +0100, Heiko Carstens wrote:
    > > > Generic code is not supposed to include irq.h. Replace this include
    > > > by linux/hardirq.h instead and add/replace an include of linux/irq.h
    > > > in asm header files where necessary.
    > > > This change should only matter for architectures that make use of
    > > > GENERIC_CLOCKEVENTS.
    > > > Architectures in question are mips, x86, arm, sh, powerpc, uml and sparc64.
    > > >
    > > > I did some cross compile tests for mips, x86_64, arm, powerpc and sparc64.
    > > > This patch fixes also build breakages caused by the include replacement in
    > > > tick-common.h.
    > >
    > > I generally dislike adding optional linux/* includes in asm/* includes -
    > > I'm nervous about this causing include loops.
    > >
    > > However, there's a separate point to be discussed here.
    > >
    > > That is, what interfaces are expected of every architecture in the kernel.
    > > If generic code wants to be able to set the affinity of interrupts, then
    > > that needs to become part of the interfaces listed in linux/interrupt.h
    > > rather than linux/irq.h.
    > >
    > > So what I suggest is this approach instead (against Linus' tree of a
    > > couple of days ago) - we move irq_set_affinity() and irq_can_set_affinity()
    > > to linux/interrupt.h, change the linux/irq.h includes to linux/interrupt.h
    > > and include asm/irq_regs.h where needed (asm/irq_regs.h is supposed to be
    > > rarely used include since not much touches the stacked parent context
    > > registers.)
    >
    > That patch makes a lot of sense and resolves all the issues.
    >
    > I push it through hrt.git and add the GENERIC_HARDIRQS dependency
    > which was requested by Heiko.

    Okay. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

    --
    Russell King
    Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
    maintainer of:


    \
     
     \ /
      Last update: 2008-03-25 20:39    [W:0.026 / U:0.188 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site