lkml.org 
[lkml]   [2008]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [6/7] Split large page mapping for AMD TSEG
On Tue, Mar 25, 2008 at 05:44:21PM +0100, Thomas Gleixner wrote:
> On Wed, 12 Mar 2008, Andi Kleen wrote:
> > +
> > + if (!direct_gbpages &&
> > + c == &boot_cpu_data && c->x86 >= 0xf && c->x86 <= 0x11) {
> > + unsigned long tseg;
>
> Can we do this at some place which is only called once ?

Nothing obvious. We could add it, but then would need to add a (imho ugly)
vendor check there first.

I think it is better to have the cpu specific code all in one place.

>
> > + /*
> > + * Split up direct mapping around the TSEG SMM area.
> > + * Don't do it for gbpages because there seems very little
> > + * benefit in doing so.
> > + */
> > + if (!rdmsrl_safe(MSR_K8_TSEG_ADDR, &tseg) &&
>
> warning: passing argument 2 of 'rdmsrl_safe' from incompatible pointer type

Yes the type has to be updated after the earlier inline change.
Easiest you just do the trivial change yourself.

-Andi



\
 
 \ /
  Last update: 2008-03-25 17:53    [W:0.105 / U:1.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site