Messages in this thread |  | | | Date | Mon, 24 Mar 2008 21:45:53 -0700 | | From | "H. Peter Anvin" <> | | Subject | Re: [PATCH] x86: enable PAT for amd k8 and fam10h | |
Yinghai Lu wrote:
>>
>> This really should be handled through a CPU flag. Specifically, it
>> should be handled by disabling the PAT flag if PAT is unusable or
>> suspect of being unusable; it should *NOT* be stashed away in a
>> completely separate piece of code.
>
> PAT patches in x86.git latest, only support some intel CPUs.
>
> if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL &&
> (boot_cpu_data.x86 == 0xF ||
> (boot_cpu_data.x86 == 6 && boot_cpu_data.x86_model >= 15))) {
> if (cpu_has_pat) {
> return 1;
> }
> }
>
> should be moved to setup_64.c?
>
Yes, which in turn should be merged with the 32-bit code in cpu/*.c.
Personally I would prefer a blacklist rather than a whitelist, but
that's nitpicking.
-=hpa
|  |