lkml.org 
[lkml]   [2008]   [Mar]   [24]   [last100]   RSS Feed
Views: [more markup]   [less markup]   [headers]   [forward]  
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] time: xtime lock vs printk
FromDaniel Walker <>
DateMon, 24 Mar 2008 07:21:55 -0700
On Mon, 2008-03-24 at 13:24 +0100, Peter Zijlstra wrote:
> -       printk(KERN_INFO "Time: %s clocksource has been installed.\n",
> +       /*
> +        * We're holding xtime lock and waking up klogd would deadlock
> +        * us on enqueue. Print without waking.
> +        */
> +       printk_nowakeup(KERN_INFO "Time: %s clocksource has been
> installed.\n",
>                clock->name);

It doesn't seem like there is a lot of potential for more xtime write
lock holders to do printk's .. We could just remove this line, or move
this printk into an __init ..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-03-24 14:25    [W:0.081 / U:0.830 seconds]
©2003-2008 Jasper Spaans