lkml.org 
[lkml]   [2008]   [Mar]   [24]   [last100]   RSS Feed
Views: [more markup]   [less markup]   [headers]   [forward]  
 
Messages in this thread
/
DateMon, 24 Mar 2008 15:10:44 +0100
FromJörn Engel <>
SubjectRe: [PATCH] 2/3 mtd: add support for flash on the SEGA Dreamcast Visual Memory Unit
On Mon, 24 March 2008 13:58:40 +0000, Adrian McMenamin wrote:
> Tempting as it is to continue the war, discretion will be the better
> part of valour here and I will give you the last word.
> 
> Of course I don't mind you sending patches. Indeed it would be very
> helpful and generous of you to do so.

Good.  The first four shouldn't change any behaviour.  Number five flips
positive error returns into negative ones.  I believe the old behaviour
is a bug.  Worth a second look to make sure.

All five patches are attached.  Hope that doesn't cause any problems.

Jörn

-- 
There are two ways of constructing a software design: one way is to make
it so simple that there are obviously no deficiencies, and the other is
to make it so complicated that there are no obvious deficiencies.
-- C. A. R. Hoare

Directly include two headers.  While unnecessary on sh, this allows the driver
to be compiled on i386 for those lacking a cross-compiler setup.

Signed-off-by: J
Minimal changes to make sparse happier.

Signed-off-by: J
Shrink the goto logic where easily possible.  Changing the return type to int
allows vmu_flash_read_char() to follow normal Linux style.

Signed-off-by: J
Trivial comment reformatting.  Old style was uncommon for Linux.

Signed-off-by: J
Change return values.
- Turn -1 into -EIO.  Possibly not the best value, but better than -EPERM.
- Change -error to error to return negative error values, as is standard.

Signed-off-by: J
\
 
 \ /
  Last update: 2008-03-24 15:13    [from the cache]
©2003-2008