![]() | |||||||||||||
Messages in this thread |
On Fri, 14 Mar 2008 15:36:17 -0400
Carlos Aguiar <carlos.aguiar@indt.org.br> wrote:
> From: Juha Yrjola <juha.yrjola@solidboot.com>
>
> Introduce new MMC multislot structure and change driver to use it.
>
> Note that MMC clocking is now enabled in mmc_omap_select_slot()
> and disabled in mmc_omap_release_slot().
>
> Signed-off-by: Juha Yrjola <juha.yrjola@solidboot.com>
> Signed-off-by: Jarkko Lavinen <jarkko.lavinen@nokia.com>
> Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
*snip*
> +
> + if (slot->pdata->name != NULL) {
> + r = device_create_file(&mmc->class_dev,
> + &dev_attr_slot_name);
> + if (r < 0)
> + goto err_remove_host;
> + }
> +
> + if (slot->pdata->get_ro != NULL) {
> + r = device_create_file(&mmc->class_dev,
> + &dev_attr_ro);
> + }
> +
I guess these should have been removed as well?
> +static void mmc_omap_remove_slot(struct mmc_omap_slot *slot)
> +{
> + struct mmc_host *mmc = slot->mmc;
> +
> + if (slot->pdata->name != NULL)
> + device_remove_file(&mmc->class_dev, &dev_attr_slot_name);
> + if (slot->pdata->get_ro != NULL)
> + device_remove_file(&mmc->class_dev, &dev_attr_ro);
> +
Same thing here.
Otherwise the patch looks fine.
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
| ||||||||||||
| Last update: 2008-03-24 12:15 [from the cache] ©2003-2008 | |||||||||||||