Messages in this thread | | | Date | Mon, 24 Mar 2008 23:09:33 +0530 | From | "Nitin Gupta" <> | Subject | Re: [PATCH 2/6] compcache: block device - internal defs |
| |
On Mon, Mar 24, 2008 at 9:55 PM, Mariusz Kozlowski <m.kozlowski@tuxland.pl> wrote: > Hi Nitin, > > > > +#define K(x) ((x) >> 10) > > +#define KB(x) ((x) << 10) > > Hm. These look cryptic unless you remember what they do. > Could have better names?
I'll give them better names/add comments.
> > > > +#define CC_DEBUG2((fmt,arg...) \ > > + printk(KERN_DEBUG C fmt,##arg) > > Unbalanced parenthesis. >
Corrected. Thanks.
- Nitin
> Just my 0.05zl. > > Mariusz >
| |