lkml.org 
[lkml]   [2008]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/6] compcache: block device - internal defs
On Mon, Mar 24, 2008 at 9:55 PM, Mariusz Kozlowski
<m.kozlowski@tuxland.pl> wrote:
> Hi Nitin,
>
>
> > +#define K(x) ((x) >> 10)
> > +#define KB(x) ((x) << 10)
>
> Hm. These look cryptic unless you remember what they do.
> Could have better names?

I'll give them better names/add comments.

>
>
> > +#define CC_DEBUG2((fmt,arg...) \
> > + printk(KERN_DEBUG C fmt,##arg)
>
> Unbalanced parenthesis.
>

Corrected. Thanks.

- Nitin

> Just my 0.05zl.
>
> Mariusz
>


\
 
 \ /
  Last update: 2008-03-24 18:43    [from the cache]
©2003-2011 Jasper Spaans