Messages in this thread | | | Date | Mon, 24 Mar 2008 18:07:07 +0100 | From | Jörn Engel <> | Subject | Re: [PATCH] 3/3 maple: update bus driver to support Dreamcast VMU |
| |
On Mon, 24 March 2008 17:04:29 +0100, Jörn Engel wrote: > > Then we should be fine. I'll try to beat the code into submission.
And here go two more interesting patches. The first is removing all locking from the mtd driver. Since the existing locking code is nearly impossibly to verify, I'd rather have something simple and wrong than something complicated and wrong.
The second rearranges the list locking a bit. Previously it was possible to touch maple_waitq or maple_sentq without holding the lock. With my limited understanding of the driver, the second patch may already be enough to prevent the type of corruption you've been seeing.
Jörn
-- If a problem has a hardware solution, and a software solution, do it in software. -- Arnd Bergmann
| |