Messages in this thread | | | Date | Mon, 24 Mar 2008 09:09:39 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH] kbuild: silence documentation GEN xml messages according to $(quiet) |
| |
On Mon, 24 Mar 2008 11:16:55 -0400 Mike Frysinger wrote:
> Signed-off-by: Mike Frysinger <vapier@gentoo.org> > --- > Documentation/DocBook/Makefile | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/Documentation/DocBook/Makefile b/Documentation/DocBook/Makefile > index 300e170..f6a4ba3 100644 > --- a/Documentation/DocBook/Makefile > +++ b/Documentation/DocBook/Makefile > @@ -186,8 +186,11 @@ quiet_cmd_fig2png = FIG2PNG $@ > > ### > # Rule to convert a .c file to inline XML documentation > + gen_xml = : > + quiet_gen_xml = echo ' GEN $@' > +silent_gen_xml = : > %.xml: %.c > - @echo ' GEN $@' > + @$($(quiet)gen_xml) > @( \ > echo "<programlisting>"; \ > expand --tabs=8 < $< | \ > --
The Makefile changes are good, but the patch description makes it appear that Mike was rushed. How about something like this?
Add rules for gen_xml and its quiet & silent variants. This causes "make -s" to be silent for gen_xml.
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
--- ~Randy
| |