lkml.org 
[lkml]   [2008]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6.25-rc6-git2] drm: fix printk format warning
ping.


On Tue, 18 Mar 2008 14:14:11 -0700 Randy Dunlap wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix gcc printk format warning:
> drivers/char/drm/ati_pcigart.c:125: warning: format '%08X' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
>
> but doesn't the %08 leave room for truncation?
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/char/drm/ati_pcigart.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> --- linux-2.6.25-rc6-git2.orig/drivers/char/drm/ati_pcigart.c
> +++ linux-2.6.25-rc6-git2/drivers/char/drm/ati_pcigart.c
> @@ -122,8 +122,9 @@ int drm_ati_pcigart_init(struct drm_devi
> } else {
> address = gart_info->addr;
> bus_address = gart_info->bus_addr;
> - DRM_DEBUG("PCI: Gart Table: VRAM %08X mapped at %08lX\n",
> - bus_address, (unsigned long)address);
> + DRM_DEBUG("PCI: Gart Table: VRAM %08llX mapped at %08lX\n",
> + (unsigned long long)bus_address,
> + (unsigned long)address);
> }
>
> pci_gart = (u32 *) address;
> --

---
~Randy


\
 
 \ /
  Last update: 2008-03-24 04:17    [W:0.367 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site