Messages in this thread | | | Subject | Re: [PATCH 120/148] include/asm-x86/suspend_32.h: checkpatch cleanups - formatting only | From | Peter Zijlstra <> | Date | Sun, 23 Mar 2008 12:16:08 +0100 |
| |
On Sun, 2008-03-23 at 11:57 +0300, Alexey Dobriyan wrote: > On Sun, Mar 23, 2008 at 01:03:35AM -0700, Joe Perches wrote: > > --- a/include/asm-x86/suspend_32.h > > +++ b/include/asm-x86/suspend_32.h > > @@ -32,11 +32,11 @@ extern unsigned long saved_edi; > > static inline void acpi_save_register_state(unsigned long return_point) > > { > > saved_eip = return_point; > > - asm volatile ("movl %%esp,%0" : "=m" (saved_esp)); > > - asm volatile ("movl %%ebp,%0" : "=m" (saved_ebp)); > > - asm volatile ("movl %%ebx,%0" : "=m" (saved_ebx)); > > - asm volatile ("movl %%edi,%0" : "=m" (saved_edi)); > > - asm volatile ("movl %%esi,%0" : "=m" (saved_esi)); > > + asm volatile("movl %%esp,%0" : "=m" (saved_esp)); > > + asm volatile("movl %%ebp,%0" : "=m" (saved_ebp)); > > + asm volatile("movl %%ebx,%0" : "=m" (saved_ebx)); > > + asm volatile("movl %%edi,%0" : "=m" (saved_edi)); > > + asm volatile("movl %%esi,%0" : "=m" (saved_esi)); > > Since when "volatile" became a function?
Agreed, this is crack.
Joe, please find something useful to contribute. Having a few cleanup patches at the beginning of a useful series isn't an issue, but such series as posted here are utterly annoying, and by the above just plain stupid.
checkpatch.pl is a guide, not a replacement for common sense.
| |