![]() | ||||||||||
Messages in this thread |
On Sat, 2008-03-22 at 19:32 +0100, Jörn Engel wrote: > On Sat, 22 March 2008 18:03:55 +0000, Adrian McMenamin wrote: > > > Without a doubt, buffering is useful. However I question how useful it > is to implement this in individual device drivers instead of once in > mtd_core.c. Well, it's obviously useful to this device. Are you making best the enemy of better? > > Given that you have ignored most of my previous comments, NAK. Not good enough, frankly. What comments have I ignored? I didn't implement your suggestion that a void* memory type become be32* because it was totally inappropriate for a type that is passed in both be32 and le32 and as u8. > I don't > mind merging code that isn't up to our standards yet. But I have a bad > feeling about a maintainer that does not understand review comments. > Since you had similar problems understanding Andrew, part of the blame > may sit on your side. > I'm sorry that you feel that way, but as you took the hump when I said that this: "Possibly the big-endian annotations need to trickly though the layers here as well." Isn't good english (and it's not) and asked you - twice - to explain what you meant. I cannot accept your summary. Adrian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | |||||||||
| Last update: 2008-03-22 19:41 [from the cache] ©2003-2008 | ||||||||||