[lkml]   [2008]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: use of preempt_count instead of in_atomic() at leds-gpio.c
    On Thu, 20 Mar 2008 20:17:23 -0700, Andrew Morton wrote:
    > in_atomic() is for core kernel use only. (...)

    Then why is it made available to drivers through <linux/hardirq.h>? If
    it's such a dangerous macro to call from drivers, it shouldn't be made
    available, or at the very least there should be a big fat warning in
    <linux/hardirq.h> that drivers aren't supposed to use it. This would
    have avoided the 23 uses cases in drivers we have right now.

    Jean Delvare

     \ /
      Last update: 2008-03-21 10:57    [W:0.017 / U:115.544 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site