Messages in this thread | | | Date | Fri, 21 Mar 2008 19:14:41 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] [5/7] Readd rdmsrl_safe |
| |
On Fri, 21 Mar 2008, Andi Kleen wrote: > > > Well all of paravirt.h uses macros. I did the same for consistency. > > > > consistency ? > > At least I consider it clean and consistent to use similar > style as the other code in that file for new code I add.
inlines are generally preferred and the existing macro pile is no excuse to add more.
> > > If you want inlines it would be better to just convert it all in one > > > go (but please only after this patch was applied) > > > > Of course. We don't want to burden work on your shoulders. > > Well you signed up for the work yourself last year ;-) It was your choice.
Yeah, I signed up for maintaining. And review is one of the tasks of a maintainer. So when I do a review and ask for a macro -> inline change I don't see that this means that I have to do the change myself.
Thanks,
tglx
| |