lkml.org 
[lkml]   [2008]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] [5/7] Readd rdmsrl_safe
    On Fri, Mar 21, 2008 at 06:58:08PM +0100, Thomas Gleixner wrote:
    > On Fri, 21 Mar 2008, Andi Kleen wrote:
    >
    > > On Fri, Mar 21, 2008 at 06:06:13PM +0100, Thomas Gleixner wrote:
    > > > On Wed, 12 Mar 2008, Andi Kleen wrote:
    > > > > RDMSR for 64bit values with exception handling.
    > > > >
    > > > > Makes it easier to deal with 64bit valued MSRs. The old 64bit code
    > > > > base had that too as checking_rdmsrl(), but it got dropped somehow.
    > > >
    > > > Yup, no users.
    > > >
    > > > > +#define rdmsrl_safe(msr,p) \
    > > > > + ({ int __err; *(p) = native_read_msr_safe(msr, &__err); __err; })
    > > > > +
    > > >
    > > > static inline please
    > >
    > > Well all of paravirt.h uses macros. I did the same for consistency.
    >
    > consistency ?

    At least I consider it clean and consistent to use similar
    style as the other code in that file for new code I add.

    >
    > > If you want inlines it would be better to just convert it all in one
    > > go (but please only after this patch was applied)
    >
    > Of course. We don't want to burden work on your shoulders.

    Well you signed up for the work yourself last year ;-) It was your choice.

    -Andi


    \
     
     \ /
      Last update: 2008-03-21 19:05    [W:0.020 / U:29.636 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site