Messages in this thread | | | Date | Fri, 21 Mar 2008 17:32:54 +0100 | From | Ingo Molnar <> | Subject | Re: [patch] forcedeth: fix locking bug with netconsole |
| |
* Jeff Garzik <jgarzik@pobox.com> wrote:
> Ingo Molnar wrote: >> Subject: forcedeth: fix locking bug with netconsole >> From: Ingo Molnar <mingo@elte.hu> >> >> while using netconsole on forcedeth, lockdep noticed the following >> locking bug: > [...] >> the fix is to disable/restore irqs instead of disable/enable. > > So we make _the_ TX fast path slower, to accomodate a path that is > rarely executed?
no strong opinion but a single PCI mmio access far outweighs any flags save/restore, so i'd not fight about something like that. I've never seen flags save/restore costs show up in NMI-driven profiles that had networking load.
Ingo
| |