lkml.org 
[lkml]   [2008]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] forcedeth: fix locking bug with netconsole

* Jeff Garzik <jgarzik@pobox.com> wrote:

> Ingo Molnar wrote:
>> Subject: forcedeth: fix locking bug with netconsole
>> From: Ingo Molnar <mingo@elte.hu>
>>
>> while using netconsole on forcedeth, lockdep noticed the following
>> locking bug:
> [...]
>> the fix is to disable/restore irqs instead of disable/enable.
>
> So we make _the_ TX fast path slower, to accomodate a path that is
> rarely executed?

no strong opinion but a single PCI mmio access far outweighs any flags
save/restore, so i'd not fight about something like that. I've never
seen flags save/restore costs show up in NMI-driven profiles that had
networking load.

Ingo


\
 
 \ /
  Last update: 2008-03-21 17:35    [W:0.039 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site