lkml.org 
[lkml]   [2008]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Memory corruption in block2mtd.c
On Thu, 20 March 2008 15:36:48 +0100, Ingo van Lil wrote:
>
> the block2mtd driver (drivers/mtd/devices/block2mtd.c) will kfree an
> on-stack pointer when handling an invalid argument line (e.g.
> block2mtd=/dev/loop0,xxx).
>
> The kfree was added some time ago when "name" was dynamically
> allocated.

Good catch.

> Signed-off-by: Ingo van Lil <inguin@gmx.de>
Acked-by: Joern Engel <joern@lazybastard.org>

> ---
>
> --- linux-2.6.23.1/drivers/mtd/devices/block2mtd.c.orig 2008-03-20
> 15:13:49.000000000 +0100
> +++ linux-2.6.23.1/drivers/mtd/devices/block2mtd.c 2008-03-20
> 15:14:09.000000000 +0100
> @@ -408,7 +408,6 @@
> if (token[1]) {
> ret = parse_num(&erase_size, token[1]);
> if (ret) {
> - kfree(name);
> parse_err("illegal erase size");
> }
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

Jörn

--
It is the mark of an educated mind to be able to entertain a thought
without accepting it.
-- Aristotle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-03-20 19:37    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site