Messages in this thread | | | From | "NeilBrown" <> | Date | Thu, 20 Mar 2008 13:31:07 +1100 (EST) | Subject | Re: Oops in NFSv4 server in 2.6.23.17 |
| |
On Thu, March 20, 2008 9:32 am, J. Bruce Fields wrote: > On Mon, Mar 17, 2008 at 10:19:20AM +1100, Neil Brown wrote: >> On Friday March 14, bfields@fieldses.org wrote: >> > On Fri, Mar 14, 2008 at 04:05:10PM -0400, bfields wrote: >> > > I find that a little contorted. So I'll go ahead and submit this >> small >> > > patch to 2.6.25 and stable now (I have since managed to reproduce >> what I >> > > believe is your bug, though my symptoms were a little different), >> and >> > > then submit to 2.6.26 some cleanup which makes this more >> understandable, >> > >> > Here's an attempt. We could break up fh_verify even more, though.--b. >> >> Looks like a good attempt. >> >> My only suggestion would be to put a comment at the top of >> nfsd_set_fh_dentry explaining what it does and who calls it. > > OK! I'm planning to just add: > > +/* > + * Use the given filehandle to look up the corresponding export and > + * dentry. On success, the results are used to set fh_export and > + * fh_dentry. > + */ > static __be32 nfsd_set_fh_dentry(struct svc_rqst *rqstp, struct svc_fh > *fhp) > { > struct knfsd_fh *fh = &fhp->fh_handle; > > (Nothing about "who calls it", but it's static and its only caller is > fh_verify, so that seemed uninteresting.) Anything else you were > looking for?
No, that's adequate. The function name has one verb and 2 (or 3) nouns, and it isn't clear how the verb relates to the nouns. The comment you gave makes that clear.
Thanks, NeilBrown
| |