lkml.org 
[lkml]   [2008]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] [keys] Always use key_get() to increment key refcount
    Date
    Arun Raghavan <arunsr@cse.iitk.ac.in> wrote:

    > Patch to use key_get() wherever the keys code manually increments the
    > key refcount.
    >
    > This should make debugging a little simpler for clients, since it
    > becomes easier to track where a key's refcount changes.

    The problem with this is that key_get() is not simply an atomic_inc(). You
    end up introducing an extra conditional into each of these places where one is
    not required. Now it's possible that the compiler's optimiser is sufficiently
    clever to get rid of them all, but do you guarantee that?

    David


    \
     
     \ /
      Last update: 2008-03-20 00:59    [W:0.020 / U:1.472 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site