lkml.org 
[lkml]   [2008]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 2/6] vfs: pnode cleanup
    On Thu, Mar 13, 2008 at 10:26:43PM +0100, Miklos Szeredi wrote:
    > Move set_mnt_shared from pnode.h to pnode.c. Change
    > CLEAR_MNT_SHARED() to clear_mnt_shared() function, and move to
    > pnode.c.

    I don't see why these two are a cleanup, actually.

    > @@ -89,20 +100,18 @@ static int do_make_slave(struct vfsmount
    > list_for_each_entry(slave_mnt, &mnt->mnt_slave_list, mnt_slave)
    > slave_mnt->mnt_master = master;
    > list_move(&mnt->mnt_slave, &master->mnt_slave_list);
    > - list_splice(&mnt->mnt_slave_list, master->mnt_slave_list.prev);
    > - INIT_LIST_HEAD(&mnt->mnt_slave_list);
    > + list_splice_init(&mnt->mnt_slave_list,
    > + master->mnt_slave_list.prev);

    Umm... OK.

    > } else {
    > - struct list_head *p = &mnt->mnt_slave_list;
    > - while (!list_empty(p)) {
    > - slave_mnt = list_first_entry(p,
    > + while (!list_empty(&mnt->mnt_slave_list)) {
    > + slave_mnt = list_first_entry(&mnt->mnt_slave_list,

    How is that better?


    > - INIT_LIST_HEAD(&mnt->mnt_slave_list);

    Fine by me.


    \
     
     \ /
      Last update: 2008-03-19 22:25    [W:0.037 / U:0.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site