Messages in this thread | | | Subject | Re: [PATCH 7/8] Remove current_tick_length() | From | john stultz <> | Date | Mon, 17 Mar 2008 18:01:04 -0700 |
| |
On Sat, 2008-03-15 at 18:14 +0100, Roman Zippel wrote: > Hi, > > On Sat, 15 Mar 2008, Ray Lee wrote: > > > Then make the original function an inline. With -O2 it should compile > > to exactly the same thing. > > This would also defeat John's intention of keeping the value static.
Well, don't mistake me for being fanatical about it. Having the values be static is cleaner, but if its a real performance issue, then clearly performance wins.
I do like Ray's suggestion, and think using the inline'd function is preferred to the raw variable, as it better establishes through use if nothing else, the read-only nature of the value outside of ntp.
thanks -john
| |