[lkml]   [2008]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    SubjectRe: [PATCH] i810fb: Fix console switch regression
    I'm sorry for the spaces in the second patch, here's a clean one with tabs.

    From: Stefan Bauer <>

    Since 4c7ffe0b9f7f40bd818fe3af51342f64c483908e ("fbdev: prevent drivers that
    have hardware cursors from calling software cursor code") every call of
    i810fb_cursor fails with -ENXIO because of a incorrect "!".

    This hasn't striked until eaa0ff15c30dc9799eb4d12660edb73aeb6d32c5 ("fix !
    versus & precedence in various places") surrounded the expression with
    braces, so that the intended behavior was inverted. That caused 'pixel
    waste' - the same line of multi-colored pixels repeated over the whole
    screen - during console switch.

    This switches back to the original pre-4c7ffe0 behavior.

    Signed-off-by: Stefan Bauer <>
    Signed-off-by: Geert Uytterhoeven <>
    Cc: Antonino Daplas <>

    --- linux-2.6/drivers/video/i810/i810_main.c.orig
    +++ linux-2.6/drivers/video/i810/i810_main.c
    @@ -1476,7 +1476,7 @@ static int i810fb_cursor(struct fb_info
    struct i810fb_par *par = info->par;
    u8 __iomem *mmio = par->mmio_start_virtual;

    - if (!(par->dev_flags & LOCKUP))
    + if (par->dev_flags & LOCKUP)
    return -ENXIO;

    if (cursor->image.width > 64 || cursor->image.height > 64)

     \ /
      Last update: 2008-03-17 16:45    [W:0.023 / U:1.736 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site