lkml.org 
[lkml]   [2008]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd()
Christoph Hellwig wrote:
> On Sat, Mar 08, 2008 at 06:45:34PM -0800, Roland Dreier wrote:
>
>> > spin_lock(&kvm_lock);
>> > + if (--kvm->refcount) {
>> > + spin_lock(&kvm_lock);
>>
>> obvious typo here...
>>
>
>












> Indeed. Any comments from the kvm developers in this approach? The
> current multi-level file refcounting seems rather bogus so I'd like
> to make some progress on this.
>
>

I'm okay with switching away from the file-based refcounts to a refcount
embedded in the kvm structures, though I'm not particularly thrilled by
it. Any reason not to use krefs for this?

--
error compiling committee.c: too many arguments to function



\
 
 \ /
  Last update: 2008-03-17 11:51    [W:0.071 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site