Messages in this thread | | | Date | Sun, 16 Mar 2008 11:13:42 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: Linux 2.6.25-rc4 |
| |
On Sun, 16 Mar 2008, Bartlomiej Zolnierkiewicz wrote: > > We don't do error handling for special commands (REQ_TYPE_ATA_*) at all, > ide_error() just dumps device's status/error register(s) and finishes early:
Well that sounds bogus too, for all the same reasons already outlined. The DRQ flag needs to be cleared up on error!
> Moreover the problem was initially narrowed down to commit > 852738f39258deafb3d89c187cb1a4050820d555 which is two commits _before_ > the one that we are currently discussing.
.. and that initial narrowing down is now in doubt, with the new one pointing to that DRQ-logic-changing commit!
IOW, Anders re-did things more carefully, and came to a new result. Why are you apparenrly ignoring that fact?
Linus
| |