Messages in this thread Patch in this message | | | From | Jiri Slaby <> | Subject | [PATCH 1/1] IDE: fix ide.h compiler warning | Date | Sun, 16 Mar 2008 17:01:58 +0100 |
| |
Fix following compiler warning by returning EINVAL In file included from ANYTHING-INCLUDING-IDE.H:45: include/linux/ide.h: In function ‘ide_hwif_setup_dma’: include/linux/ide.h:1022: warning: no return statement in function returning non-void
This fix is only for CONFIG_BLK_DEV_IDEDMA_PCI=n configs and is introduced by ide: do complete DMA setup in ->init_dma method.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com> Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- include/linux/ide.h | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/linux/ide.h b/include/linux/ide.h index 83ddaf0..bd8d751 100644 --- a/include/linux/ide.h +++ b/include/linux/ide.h @@ -1016,7 +1016,10 @@ unsigned long ide_pci_dma_base(ide_hwif_t *, const struct ide_port_info *); int ide_hwif_setup_dma(ide_hwif_t *, const struct ide_port_info *); #else static inline int ide_hwif_setup_dma(ide_hwif_t *hwif, - const struct ide_port_info *d) { } + const struct ide_port_info *d) +{ + return -EINVAL; +} #endif extern void default_hwif_iops(ide_hwif_t *); -- 1.5.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |