![]() | ||||||||||
Messages in this thread Patch in this message |
It's safer to use KSYM_NAME_LEN instead of numeric constant because we could get buffer overrun someday if KSYM_NAME_LEN would be changed to a bigger value. Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- I've patched 64bit version but forgot about 32bit. So lets fix it too. Index: linux-2.6.git/arch/x86/kernel/traps_32.c =================================================================== --- linux-2.6.git.orig/arch/x86/kernel/traps_32.c 2008-02-09 22:27:13.000000000 +0300 +++ linux-2.6.git/arch/x86/kernel/traps_32.c 2008-03-15 11:21:16.000000000 +0300 @@ -109,7 +109,7 @@ void printk_address(unsigned long addres const char *symname; char *modname; char *delim = ":"; - char namebuf[128]; + char namebuf[KSYM_NAME_LEN]; char reliab[4] = ""; symname = kallsyms_lookup(address, &symsize, &offset, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | |||||||||
| Last update: 2008-03-15 09:39 [from the cache] ©2003-2008 | ||||||||||