Messages in this thread |  | | | Date | Sat, 15 Mar 2008 05:28:24 +0100 (CET) | | From | Roman Zippel <> | | Subject | Re: [PATCH 1/5] split clocksource adjustment from clockosurce mult | |
Hi,
On Fri, 14 Mar 2008, john stultz wrote:
> @@ -179,7 +181,7 @@ static inline cycle_t clocksource_read(struct clocksource *cs)
> static inline s64 cyc2ns(struct clocksource *cs, cycle_t cycles)
> {
> u64 ret = (u64)cycles;
> - ret = (ret * cs->mult) >> cs->shift;
> + ret = (ret * (cs->mult + cs->mult_adj)) >> cs->shift;
> return ret;
> }
This add an extra memory access and extra instruction to a code path, we
should keep as short as possible.
I'd rather add a mult_raw or mult_org and use that for your next patch.
bye, Roman
|  |