[lkml]   [2008]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH v1] change likeliness accounting

    On Fri, 2008-03-14 at 00:06 +0100, Roel Kluin wrote:

    > - seq_printf(out, "|%9u|%9u\t%s()@:%s@%d\n", true, false,
    > - entry->func, entry->file, entry->line);
    > + sprint_symbol(function, entry->caller);
    > + seq_printf(out, "|%9u|%9u\t%s()@:%u\n", pos, neg, function,
    > + entry->label >> LP_LINE_SHIFT);

    Looks like we're missing a "|" after the second %9u above .. You could
    add that as long as your modifying this area.. Also your tabbing is a
    little too heavy ..

    I wonder if you think the change to saving the caller EIP is better than
    saving the file name? The size saving in the likeliness struct is nice,
    but since this is for debugging is not at all required ..

    Overall it looks like a nice update/cleanup ..

    (CC'd Andrew and Hua..)


     \ /
      Last update: 2008-03-14 20:57    [W:0.020 / U:4.344 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site