[lkml]   [2008]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] THERMAL must not select HWMON
On Fri, Mar 14, 2008 at 11:21:12AM -0700, Randy Dunlap wrote:

[ select forces HWMON to yes even if deps are never applicable ]

> Yes, that's a known & longstanding problem (that select does not
> follow/honor dependencies).


So THERMAL can't select HWMON, instead it needs to do a proper depends.


Signed-off-by: Bastian Blank <>
Cc: Zhang Rui <>

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 3ab313e..394912c 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -4,7 +4,7 @@

menuconfig THERMAL
bool "Generic Thermal sysfs driver"
- select HWMON
+ depends on HWMON
default y
Generic Thermal Sysfs driver offers a generic mechanism for
You canna change the laws of physics, Captain; I've got to have thirty minutes![unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2008-03-14 19:41    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean