Messages in this thread | | | Date | Fri, 14 Mar 2008 19:04:01 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH] Mark early_printk as asmlinkage |
| |
On Wed 2008-03-12 15:04:43, H. Peter Anvin wrote: > Jiri Slaby wrote: > >It's not explicitly marked as asmlinkage, but invoked > >from x86_32 > >startup code with parameters on stack. > > > >No other architectures define early_printk and none of > >them are affected > >by this change, since defines asmlinkage as empty token. > > NAK. > > The regparm ABI for x86-32 uses parameters on the stack > when the function is varadic (as it is here), so this is > unnecessary.
I'd call asmlinkage kind of documentation, then. Not everyone is as good with x86 abi as you are...
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |