Messages in this thread | | | Date | Thu, 13 Mar 2008 11:06:10 +0100 (CET) | From | Guennadi Liakhovetski <> | Subject | Re: pcibios_scanned needs to be set in ACPI? (was Re: 2.6.25-rc5: Reported regressions from 2.6.24) |
| |
On Wed, 12 Mar 2008, Greg KH wrote:
> On Wed, Mar 12, 2008 at 04:09:17PM -0700, Linus Torvalds wrote: > > > > > > On Wed, 12 Mar 2008, Greg KH wrote: > > > > > > I can't get a box here to produce both of those PCI: messages myself, > > > and neither can Len, so something is really odd here. > > Ok, stupid me, this was my fault. I was assuming that pci busses would > never be registered multiple times with the pci core. Obviously this > isn't true. The previous patch I proposed was only paying attention to > the PCI devices, and that logic is just fine (it's already protected > when it is attempted to be registered multiple times.) > > So, the patch below fixes the issue for me, and reboot seems to work as > well. > > Guennadi, can you test this out on your machine?
Yes, it fixes all _3_ startup warnings and lets the machine reboot and power off again. 3 warnings are the 2 reported as a regression from 2.6.24, and one present also under 2.6.24:
PCI: Probing PCI hardware sysfs: duplicate filename 'bridge' can not be created WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() Pid: 1, comm: swapper Not tainted 2.6.24-hires-nohz #2 [<c010541a>] show_trace_log_lvl+0x1a/0x30 [<c0105ed2>] show_trace+0x12/0x20 [<c010675e>] dump_stack+0x6e/0x80 [<c01b246d>] sysfs_add_one+0x9d/0xe0 [<c01b328b>] sysfs_create_link+0x8b/0x130 [<c01f9f14>] pci_bus_add_devices+0x94/0x120 [<c03f3920>] pci_legacy_init+0x50/0xf0 [<c03d95f2>] kernel_init+0x142/0x320 [<c0104fe3>] kernel_thread_helper+0x7/0x14 ======================= pci 0000:00:01.0: Error creating sysfs bridge symlink, continuing...
So, well done! I was going to disturb you with that one after 2.6.25, now I don't have to any more, unless we want it fixed in 2.6.24-stable.
> thanks for your patience,
always at your disposal:-)
Thanks Guennadi --- Guennadi Liakhovetski
| |