Messages in this thread | | | Date | Thu, 13 Mar 2008 17:51:39 -0700 | From | Matthew Dharm <> | Subject | Re: [PATCH] mass storage : emulation of sat scsi_pass_thru with ATACB |
| |
On Thu, Mar 13, 2008 at 10:22:09PM +0100, matthieu castet wrote: > Matthew Dharm wrote: > >On Sun, Mar 09, 2008 at 10:42:50PM +0100, matthieu castet wrote: > >>Hi > >> > >>here an update version of the patch > > > >We're getting very close here.
> + unsigned char sk, asc, ascq;
> + sk = RECOVERED_ERROR; > + asc = 0; /* ATA PASS THROUGH INFORMATION AVAILABLE */ > + ascq = 0x1D;
> + /* XXX we should generate sk, asc, ascq from status and error > + * regs > + * (see 11.1 Error translation ? ATA device error to SCSI error map) > + * and ata_to_sense_error from libata. > + */ > + sb[1] = sk; > + sb[2] = asc; > + sb[3] = ascq;
I may have missed this in an earlier patch, but why to you declare and use these 3 variables like this? Seems odd and confusing to me....
Matt
-- Matthew Dharm Home: mdharm-usb@one-eyed-alien.net Maintainer, Linux USB Mass Storage Driver
It was a new hope. -- Dust Puppy User Friendly, 12/25/1998 [unhandled content-type:application/pgp-signature] | |