Messages in this thread |  | | | Date | Thu, 13 Mar 2008 21:54:27 +0100 | | From | Haavard Skinnemoen <> | | Subject | Re: [PATCH 02/10] atmel_serial: Fix build on avr32 with CONFIG_PM enabled |
| |
On Thu, 13 Mar 2008 12:37:40 -0800 David Brownell <david-b@pacbell.net> wrote:
> On Thursday 13 March 2008, Haavard Skinnemoen wrote: > > AVR32 doesn't have at91_suspend_entering_slow_clock(). Just assume the > > clock will keep running for now. > > Well, it should acquire the clk_must_disable() or somesuch... :)
Indeed. But that interface doesn't exist yet...
> By the way, I noticed a goof in this driver's clock management. > It should leave the clock off whenever the device isn't open. > As it is, it wastes power both at runtime and during suspend.
Right. I suspect you'll find a similar goofs in lots of drivers if you go looking. I intend to go through all the drivers I care about and see if I can tighten up the clock management a bit. There are probably a few missing or half-assed suspend/resume implementations around too.
Haavard
|  |