Messages in this thread |  | | | Date | Wed, 12 Mar 2008 13:08:11 +0530 | | From | Balbir Singh <> | | Subject | Re: [PATCH rc5-mm1 1/3] mm-have-zonelist: fix memcg ooms |
Hugh Dickins wrote:
> Memcgroups up against their limit were OOMing unjustifiably on x86_32
> with highmem: pages ripe for freeing were not being found.
>
> It's because the zonelist changes in vmscan.c now derive zone from gfp_mask,
> and the gfp mask being passed into try_to_free_mem_cgroup_pages is atuned
> to allocating a struct page_cgroup (__GFP_HIGHMEM masked off), whereas here
> we need to be scanning highmem zones.
>
Very good catch. I see a high_zoneidx field being derived from gfp_mask -mm.
I've been looking at mainline code too often.
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
|  |