lkml.org 
[lkml]   [2008]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: pcibios_scanned needs to be set in ACPI? (was Re: 2.6.25-rc5: Reported regressions from 2.6.24)


    On Wed, 12 Mar 2008, Greg KH wrote:
    >
    > Actually, here's a simple patch from -next that should test this logic
    > for you. Can you let me know if this solves the start up WARNING dump
    > for you?

    This patch looks bogus.

    Why do you introduce a "dev->is_added" field that apparently has to match
    the old "list_empty(&dev->global_list)" 1:1 anyway?

    In other words: when is it *ever* permissible for "is_added" to have a
    different value from the "list_empty(..)" logic? And if they must always
    match (and it looks like they have to, since you set and clear the flag
    exactly when you add/remove it from the list), then what exactly is this
    supposed to fix?
    Linus


    \
     
     \ /
      Last update: 2008-03-12 23:29    [from the cache]
    ©2003-2011 Jasper Spaans. Advertise on this site