Messages in this thread |  | | | Subject | Re: [PATCH] Re: WAN: new PPP code for generic HDLC | | From | Krzysztof Halasa <> | | Date | Wed, 12 Mar 2008 20:25:10 +0100 |
Stephen Hemminger <shemminger@vyatta.com> writes:
>> +struct hdlc_header {
>> + u8 address;
>> + u8 control;
>> + __be16 protocol;
>> +} __attribute__ ((packed));
>> +
>> +struct cp_header {
>> + u8 code;
>> + u8 id;
>> + __be16 len;
>> +} __attribute__ ((packed));
>> +
>
> If I remember correctly, the packed is unnecessary for structures like this
> and causes GCC to generate worse code.
Interesting. Gcc obviously will do the right thing without "packed",
at least on "current" architectures, but I don't know what the C
standard says. I will remove it, thanks.
--
Krzysztof Halasa
|  |