lkml.org 
[lkml]   [2008]   [Mar]   [12]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 12 Mar 2008 14:15:57 +0900
FromTejun Heo <>
SubjectRe: [PATCH] libata: Register for dock events when the drive is inside a dock station
Hello, Holger.

Holger Macht wrote:
>> dev_notify is being registered with a pointer to ap. No wonder it causes
>
> It seems this change is missing from your patch. I've attached a fixed
> version...

Ah... I must have sent the wrong version of patch. Thanks for the fix.

>> strange dereferences later on. Attached is the fixed patch. Can you
>> please give it a shot?
>
> ...and now the good news...the new patch works flawlessly with
> 2.6.25-rc5...
>
> undocking...
> ata5.00: disabled
> ata5.00: detaching (SCSI 4:0:0:0)
> ACPI: \_SB_.GDCK - undocking
> usb 1-6: USB disconnect, address 5
>
> docking...
> ACPI: \_SB_.GDCK - docking
> ata5: exception Emask 0x10 SAct 0x0 SErr 0x0 action 0xa frozen
> ata5: ACPI event
> ata5: soft resetting link
> ata5.00: ATAPI: HL-DT-ST DVDRAM GSA-4083N, 1.08, max UDMA/33
> ata5.00: configured for UDMA/33
> ata5: exception Emask 0x10 SAct 0x0 SErr 0x0 action 0x1 t4
> ata5: ACPI event
> ata5: soft resetting link
> ata5.00: configured for UDMA/33
> ata5: EH complete
> scsi 4:0:0:0: CD-ROM HL-DT-ST DVDRAM GSA-4083N 1.08 PQ: 0 ANSI: 5
> sr0: scsi3-mmc drive: 24x/24x writer dvd-ram cd/rw xa/form2 cdda tray
> sr 4:0:0:0: Attached scsi CD-ROM sr0
> sr 4:0:0:0: Attached scsi generic sg1 type 5

Super, I'll forward the patch upstream.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2008-03-12 06:19    [from the cache]
©2003-2009