lkml.org 
[lkml]   [2008]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Terminate hugetlbfs mount argument list
On Tue, Mar 11, 2008 at 03:48:46PM -0700, Roland Dreier wrote:
> > The match_table_t for the mount arguments in hugetlbfs wasn't
> > terminated as match_tokens expect. I didn't see a crash just code
> > audit, but it's still safer to terminate it in case the variables after
> > that in .data are not NULL.
>
> I think you're misunderstanding the match_token() interface. The
> comment before match_token() says:

Hmm indeed I did. To my defense it's a weird unusual coding pattern
that tricked me. What good is it to give terminator elements own enum values?

-Andi


\
 
 \ /
  Last update: 2008-03-11 23:57    [W:0.052 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site