Messages in this thread Patch in this message | | | From | Rusty Russell <> | Subject | [PATCH] aio_write should tell userspace about partial writes | Date | Wed, 12 Mar 2008 09:39:59 +1100 |
| |
[ Linus, please apply. This patch was discussed and acked before, but somehow got lost. ]
When an AIO write gets a non-retry error after writing some data (eg. ENOSPC), it should return the amount written already, not the error. Just like write() is supposed to.
This was found by the libaio test suite.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Acked-By: Zach Brown <zach.brown@oracle.com> --- fs/aio.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff -r c36fc295bb75 fs/aio.c --- a/fs/aio.c Tue Mar 11 09:04:47 2008 +1100 +++ b/fs/aio.c Tue Mar 11 09:05:54 2008 +1100 @@ -1358,6 +1358,13 @@ static ssize_t aio_rw_vect_retry(struct && iocb->ki_nbytes - iocb->ki_left) ret = iocb->ki_nbytes - iocb->ki_left; + /* If we managed to write some out we return that, rather than + * the eventual error. */ + if (opcode == IOCB_CMD_PWRITEV + && ret < 0 && ret != -EIOCBQUEUED && ret != -EIOCBRETRY + && iocb->ki_nbytes - iocb->ki_left) + ret = iocb->ki_nbytes - iocb->ki_left; + return ret; }
| |