Messages in this thread | | | Date | Tue, 11 Mar 2008 22:02:32 +0100 | From | Wim Van Sebroeck <> | Subject | Re: [WATCHDOG] v2.5.25-rc patches |
| |
Hi Oliver,
> this patch can cause serious problems in the case, that someone use it > with an it8712 rev. 8 and above. ... > Your patch changes it8712f_wdt.c in function t8712f_wdt_update_margin(): > > >- superio_outb((margin > 255) ? (margin / 60) : margin, WDT_TIMEOUT); > >+ if (revision >= 0x08) > >+ superio_outw(units, WDT_TIMEOUT); > >+ else > >+ superio_outb(units, WDT_TIMEOUT); > > but here you can't use superio_outw, because the bytes are swapped > --historical reason. > > I suggest to substitute > superio_outw(units, WDT_TIMEOUT); > with > superio_outb(units >> 8, WDT_TIMEOUT + 1); > superio_outb(units, WDT_TIMEOUT); >
Can you keep "Andrew Paprocki" <andrew@ishiboo.com> in the loop? Can you also create a patch and test it together with Andrew? We need to make sure that we fix this before 2.6.25 is there.
Thanks, Wim.
| |