Messages in this thread |  | | | Subject | RE: [PATCH 1/2] Fix a bug about BUG_ON() on DMA engine capability DMA_INTERRUPT. | | Date | Tue, 11 Mar 2008 16:42:19 -0000 | | From | "Sosnowski, Maciej" <> |
| |
> ---------- Original message ---------- > From: Zhang Wei <wei.zhang@freescale.com> > Date: Mar 11, 2008 4:25 AM > Subject: [PATCH 1/2] Fix a bug about BUG_ON() on DMA engine capability > DMA_INTERRUPT. > To: dan.j.williams@intel.com > Cc: linux-kernel@vger.kernel.org, Zhang Wei <wei.zhang@freescale.com> > > > The device->device_prep_dma_interrupt function is used by > DMA_INTERRUPT capability, not DMA_ZERO_SUM. > > Signed-off-by: Zhang Wei <wei.zhang@freescale.com> > --- > drivers/dma/dmaengine.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c > index 2996523..8db0e7f 100644 > --- a/drivers/dma/dmaengine.c > +++ b/drivers/dma/dmaengine.c > @@ -357,7 +357,7 @@ int dma_async_device_register(struct dma_device *device) > !device->device_prep_dma_zero_sum); > BUG_ON(dma_has_cap(DMA_MEMSET, device->cap_mask) && > !device->device_prep_dma_memset); > - BUG_ON(dma_has_cap(DMA_ZERO_SUM, device->cap_mask) && > + BUG_ON(dma_has_cap(DMA_INTERRUPT, device->cap_mask) && > !device->device_prep_dma_interrupt); > > BUG_ON(!device->device_alloc_chan_resources); > -- > 1.5.4
Acked-by: Maciej Sosnowski <maciej.sosnowski@intel.com> --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. z siedziba w Gdansku ul. Slowackiego 173 80-298 Gdansk Sad Rejonowy Gdansk Polnoc w Gdansku, VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, numer KRS 101882
NIP 957-07-52-316 Kapital zakladowy 200.000 zl
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
|  |