Messages in this thread | | | Date | Mon, 10 Mar 2008 13:56:30 +0100 | From | Pierre Ossman <> | Subject | Re: MMC: logical-bitwise and confusion in tifm_sd_transfer_data()? |
| |
On Sun, 09 Mar 2008 21:31:08 +0100 Roel Kluin <12o3l@tiscali.nl> wrote:
> from drivers/mmc/host/tifm_sd.c:183: > > if ((r_data->flags & MMC_DATA_WRITE) > && DATA_CARRY) > > shouldn't this be bit-wise &?
First off, I'm not the maintainer of that driver, Alex Dubov is.
Second, the code seems broken, but not in the way you suggest. It should probably have been:
if ((r_data->flags & MMC_DATA_WRITE) && (host->cmd_flags & DATA_CARRY))
Alex, could you have a look?
Rgds -- -- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org
| |