Messages in this thread | | | Date | Mon, 10 Mar 2008 13:03:41 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH -mm] extend sysrq-p functionality to cover all CPUs |
| |
On Mon, 10 Mar 2008 09:24:13 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
> > however just > > sysrq-p seems like a waste to have because it will probably not > > print anything useful on a large CPU system... > > Yeah, sometimes it helps to keep hitting it until you get the right CPU, > but that rather depends on interrupt distribution. > > It would be neat to suppress the trace for idle CPUs. I don't _think_ > there's a need to display the trace for idle CPUs in sysrq-P? > > > If you still want it to be a separate letter, just let me know > > which one of the last four I should take. > > l :)
OK, I'll do that. I will also change the show_lock to spinlock_irq_save just in case sysrq-p gets invoked from multiple cpus simultaneously.
I'll send you the updated patch in a separate email, so the changelog and commit logs do not have this discussion.
| |